RFR: JDK-8085822 JEP 223: New Version-String Scheme (initial integration) (original) (raw)

Mon Jun 8 23:31:20 UTC 2015

 L4076: # Verify that a given string represent a valid version 
 L20186-20189: indent for the block is off

 L20256-20259: indent for the block is off

 L20262:     as_fn_error $? "--with--version-string must have a 
 L20275:       # Unspecified numerical fields is interpreted as 0.
     Grammar: 'is interpreted' -> 'are interpreted'

 L20286:         as_fn_error $? "Version string contains + but both 
 L20292:       as_fn_error $? "--with--version-string fails to parse
     The '--with--version...' part doesn't match previous usages where
     '--with-version...' is used

 L20297-L20302: indent for the block is off

 L20307:       as_fn_error $? "--with--version-pre-base must have a 
 L20327-20332: indent for the block is off

 L20337:       as_fn_error $? "--with--version-pre-debuglevel must 
 L20361-20366: indent for the block is off

 L20371:       as_fn_error $? "--with--version-opt must have...
 L20379:         { <span class="katex"><span class="katex-mathml"><math xmlns="http://www.w3.org/1998/Math/MathML"><semantics><mrow><mi>a</mi><msub><mi>s</mi><mi>e</mi></msub><mi>c</mi><mi>h</mi><mi>o</mi><mi mathvariant="normal">&quot;</mi></mrow><annotation encoding="application/x-tex">as_echo &quot;</annotation></semantics></math></span><span class="katex-html" aria-hidden="true"><span class="base"><span class="strut" style="height:0.8444em;vertical-align:-0.15em;"></span><span class="mord mathnormal">a</span><span class="mord"><span class="mord mathnormal">s</span><span class="msupsub"><span class="vlist-t vlist-t2"><span class="vlist-r"><span class="vlist" style="height:0.1514em;"><span style="top:-2.55em;margin-left:0em;margin-right:0.05em;"><span class="pstrut" style="height:2.7em;"></span><span class="sizing reset-size6 size3 mtight"><span class="mord mathnormal mtight">e</span></span></span></span><span class="vlist-s"></span></span><span class="vlist-r"><span class="vlist" style="height:0.15em;"><span></span></span></span></span></span></span><span class="mord mathnormal">c</span><span class="mord mathnormal">h</span><span class="mord mathnormal">o</span><span class="mord">&quot;</span></span></span></span>as_me:${as_lineno-$LINENO}: WARNING: 
     At this point, I'm going to stop pointing out the 
 L20388-L20388: indent is off by one

 L20388:        username=`$ECHO "$USER" | $TR -d -c '[a-z][A-Z][0-9]'`
     This assumes that the "USER" variable is set. Should there
     be a check for "" and perhaps use "no_user_specified" or
     something like that? Perhaps the build setup always makes
     sure that "USER" is set to something. Don't know.

 L20395-L20400: indent for the block is off

 L20413-L20431: indent of all blocks in this range are off

 L20444-L20449: indent for the block is off

 L20457-L20475: indent of all blocks in this range are off

 L20486-L20491: indent for the block is off

 L20504-L20522: indent of all blocks in this range are off

 L20533-L20538: indent for the block is off

 L20551-L20569: indent of all blocks in this range are off

 L20580-L20585: indent for the block is off

 L20598-L20616: indent of all blocks in this range are off
 No comments.
     Since you're ripping out vestigial version support, I think this
     function can go away since this is version 9 and newer. Don't 
     Granted we don't often triage 'javac' with different JVMs, but...