RFR(XXS): 8086073: Fix PrintStubCode for empty StubCodeGenerator. (original) (raw)

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Jun 10 15:01:01 UTC 2015

Vladimir, Lois, thanks for the review!

Could one of you please sponsor this? Iadded the Reviewed-by comment, so you can take the change as-is.

Thanks and best regards, Goetz.

-----Original Message----- From: Lois Foltan [mailto:lois.foltan at oracle.com] Sent: Mittwoch, 10. Juni 2015 13:14 To: Lindenmaier, Goetz Cc: HotSpot Developers Subject: Re: RFR(XXS): 8086073: Fix PrintStubCode for empty StubCodeGenerator.

Looks good. Lois

On 6/10/2015 2:46 AM, Lindenmaier, Goetz wrote:

Hi,

PrintStubCode runs into an assertion if a StubCodeGenerator that never generated a stub is deleted. This happens for ICacheStubGenerator on ppc, as we implement the flushing with inline assembly and don't generate a stub. The fix is to check for an empty list in the assertion. Please review and sponsor this tiny fix. http://cr.openjdk.java.net/~goetz/webrevs/8086073-PSC/webrev.01/

Best regards and thanks, Goetz.

More information about the hotspot-dev mailing list