RFR(XS) 8098552: 8079792 breaks Zero builds without precompiled headers. (original) (raw)
Erik Helin erik.helin at oracle.com
Mon Jun 15 12:16:43 UTC 2015
- Previous message: RFR(XS) 8098552: 8079792 breaks Zero builds without precompiled headers.
- Next message: RFR(XS) 8098552: 8079792 breaks Zero builds without precompiled headers.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 2015-06-15, Stefan Johansson wrote:
Hi Severin,
Fix is correct, but we try to keep the includes sorted so please change it to be: #include "memory/allocation.hpp" +#include "memory/memRegion.hpp" #include "utilities/debug.hpp" I'm not a reviewer, but can sponsor this change and push it as soon as we get a Reviewer to look at it.
Pending the comment above by Stefan, the patch looks good. Reviewed.
Thanks, Erik
Thanks, Stefan
On 2015-06-15 11:58, Severin Gehwolf wrote: >Hi, > >Could somebody please review and sponsor this trivial fix? The issue is >that the Zero build fails with precompiled headers turned off (other >builds probably too, but I haven't checked). The fix is to include >memRegion.hpp in g1/g1BiasedArray.hpp since it uses MemRegion. > >Bug: https://bugs.openjdk.java.net/browse/JDK-8098552 >webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8098552/webrev.01/ > >Thanks, >Severin >
- Previous message: RFR(XS) 8098552: 8079792 breaks Zero builds without precompiled headers.
- Next message: RFR(XS) 8098552: 8079792 breaks Zero builds without precompiled headers.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]