Ping: RFR(M): 8086069: Adapt runtime calls to recent intrinsics to pass ints as long (original) (raw)
Lindenmaier, Goetz goetz.lindenmaier at sap.com
Mon Jun 15 15:30:16 UTC 2015
- Previous message: RFR(s): 8078513: [linux] Clean up code relevant to LinuxThreads implementation
- Next message: Ping: RFR(M): 8086069: Adapt runtime calls to recent intrinsics to pass ints as long
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi,
Could someone please have a look at this change?
I had a look whether I can push the functionality down to make_runtime_call(). This would simplify matters a lot. But as the TypeFunc is hashed, I can not change it any more in make_runtime_call().
@aarch-people: I saw you have CCallingConventionRequiresIntsAsLongs set. Could you please check whether this breaks your intinsics, e.g., multiplyToLen? (We assure in sharedRuntime_ppc.cpp, c_calling_convention() that no INT types end up there.)
Thanks, Goetz
-----Original Message----- From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Lindenmaier, Goetz Sent: Dienstag, 9. Juni 2015 17:18 To: HotSpot Developers Subject: RFR(M): 8086069: Adapt runtime calls to recent intrinsics to pass ints as long
Hi,
we are working on porting the recently* added intrinsics to PPC. As these use runtime calls, the calls must obey to the platform ABI, which requires that ints are passed as longs.
We made a similar change in "8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints." It adapts the calls if CCallingConventionRequiresIntsAsLongs is set.
This change adapts the calls to multiplyToLen, CRC32, AES, SHA accordingly.
Please review this change. I please need a sponsor. http://cr.openjdk.java.net/~goetz/webrevs/8086069-call_conv/webrev.01/
Best regards, Goetz
- i.e., added after making our initial port
- Previous message: RFR(s): 8078513: [linux] Clean up code relevant to LinuxThreads implementation
- Next message: Ping: RFR(M): 8086069: Adapt runtime calls to recent intrinsics to pass ints as long
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]