RFR(XS): 8129423: Fix unlink() of LogCompilation tmp files lost in merge of 8007993 and 8060074. (original) (raw)

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Jun 23 02:11:47 UTC 2015

+1. I submitted JPRT job to push it.

Thanks, Vladimir

On 6/22/15 7:21 AM, Volker Simonis wrote:

Hi Goetz,

thanks for finding this bug. I agree with your analysis and think your fix is good. Regards, Volker

On Mon, Jun 22, 2015 at 2:38 PM, Lindenmaier, Goetz <goetz.lindenmaier at sap.com> wrote: Hi,

I detected a small flaw introduced by a merge. This webrev fixes it: http://cr.openjdk.java.net/~goetz/webrevs/8129423-LogComp/webrev-01/ Please review this fix. I please need a sponsor. With LogCompilation each compiler thread writes information to its own temp log file. During shutdown these files are concatenated into a single log file with the specified name. The temp files should be deleted, but we found files of jtreg test TestUnstableIfTrap.java left over in the /tmp directory. Also, a simple run with LogCompilation leaves these files in the /tmp directory. 8007993 fixed a problem with writing these log files and moved the unlink() of the temp files. This unlink() got lost in the merge with 8060074. Merge: http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/674657ff61c6 8060074: http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/a0dd995271c4 8007993: http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/c13eb14ebf5c Best regards, Goetz.

More information about the hotspot-dev mailing list