RFR: 8087322: Implement a Semaphore utility class (original) (raw)
Stefan Karlsson stefan.karlsson at oracle.com
Thu Jun 25 17:24:50 UTC 2015
- Previous message: RFR: 8087322: Implement a Semaphore utility class
- Next message: RFR: 8087322: Implement a Semaphore utility class
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 2015-06-25 19:07, Kim Barrett wrote:
On Jun 25, 2015, at 12:42 PM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
Hi all,
Updated webrev: http://cr.openjdk.java.net/~stefank/8087322/webrev.05.delta http://cr.openjdk.java.net/~stefank/8087322/webrev.05 One minor thing that I unfortunately forgot to include in previous comments: I think Semaphore::impl should be private, not protected.
I agree.
I don’t need a new webrev if you want to fix that.
Looks good otherwise.
Great. Thanks for reviewing!
StefanK
- Previous message: RFR: 8087322: Implement a Semaphore utility class
- Next message: RFR: 8087322: Implement a Semaphore utility class
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]