RFR(S): 8130036: Fix problems with imprecise C++ coding. (original) (raw)
Lindenmaier, Goetz goetz.lindenmaier at sap.com
Mon Jun 29 10:44:35 UTC 2015
- Previous message: RFR(S): 8130036: Fix problems with imprecise C++ coding.
- Next message: RFR(S): 8130036: Fix problems with imprecise C++ coding.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Thanks David!
Best regards, Goetz.
-----Original Message----- From: David Holmes [mailto:david.holmes at oracle.com] Sent: Montag, 29. Juni 2015 11:26 To: Lindenmaier, Goetz; HotSpot Developers Cc: Zeller, Arno Subject: Re: RFR(S): 8130036: Fix problems with imprecise C++ coding.
Hi Goetz,
Good catches! If no-one steps in overnight I'll take care of this in my morning.
Thanks, David
On 29/06/2015 6:30 PM, Lindenmaier, Goetz wrote:
Hi,
We detected some minor, but obviously wrong coding issues we would like to fix. In two places {} are missing after an if, whilst there are two statements that depend on the condition (CHECK macro expands to another statement). In compilerOracle.cpp, a wrong size is passed to jiosnprintf(). Please review this change. I please need a sponsor. http://cr.openjdk.java.net/~goetz/webrevs/8130036blocks/webrev.01/8130036blocks-hs-rt.changeset Best regards, Goetz. Sorry for the resend, the subject was missing ...
- Previous message: RFR(S): 8130036: Fix problems with imprecise C++ coding.
- Next message: RFR(S): 8130036: Fix problems with imprecise C++ coding.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]