RFR: JDK-8138692: libjsig compilation is missing EXTRA_CFLAGS on macosx (original) (raw)
Erik Joelsson erik.joelsson at oracle.com
Thu Oct 1 13:31:36 UTC 2015
- Previous message: [8u] Request for Approval and Review: JDK-8136980: build for 8u65 and 8u66 for solaris platforms is failing
- Next message: RFR: JDK-8138692: libjsig compilation is missing EXTRA_CFLAGS on macosx
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hello,
Please review this trivial fix for compiling libjsig on macosx.
The compilation of libjsig on macosx is currently not getting the EXTRA_CFLAGS supplied to the hotspot build. This means any kind of sysroot/sdkname setting from configure isn't honored. Historically this has likely not mattered at all, but in the compiler upgrade project, it matters a great deal.
Bug: https://bugs.openjdk.java.net/browse/JDK-8138692 Patch: diff -r 983c56341c80 make/bsd/makefiles/jsig.make --- a/make/bsd/makefiles/jsig.make +++ b/make/bsd/makefiles/jsig.make @@ -62,7 +62,7 @@ (LIBJSIG):(LIBJSIG): (LIBJSIG):(JSIGSRCDIR)/jsig.c $(LIBJSIG_MAPFILE) @echo $(LOG_INFO) Making signal interposition lib... (QUIETLY)(QUIETLY) (QUIETLY)(CC) (SYMFLAG)(SYMFLAG) (SYMFLAG)(ARCHFLAG) (SHAREDFLAG)(SHARED_FLAG) (SHAREDFLAG)(PICFLAG) \
<span class="katex"><span class="katex-mathml"><math xmlns="http://www.w3.org/1998/Math/MathML"><semantics><mrow><mo stretchy="false">(</mo><mi>L</mi><mi>F</mi><mi>L</mi><mi>A</mi><mi>G</mi><msub><mi>S</mi><mi>J</mi></msub><mi>S</mi><mi>I</mi><mi>G</mi><mo stretchy="false">)</mo></mrow><annotation encoding="application/x-tex">(LFLAGS_JSIG) </annotation></semantics></math></span><span class="katex-html" aria-hidden="true"><span class="base"><span class="strut" style="height:1em;vertical-align:-0.25em;"></span><span class="mopen">(</span><span class="mord mathnormal">L</span><span class="mord mathnormal" style="margin-right:0.13889em;">F</span><span class="mord mathnormal">L</span><span class="mord mathnormal">A</span><span class="mord mathnormal">G</span><span class="mord"><span class="mord mathnormal" style="margin-right:0.05764em;">S</span><span class="msupsub"><span class="vlist-t vlist-t2"><span class="vlist-r"><span class="vlist" style="height:0.3283em;"><span style="top:-2.55em;margin-left:-0.0576em;margin-right:0.05em;"><span class="pstrut" style="height:2.7em;"></span><span class="sizing reset-size6 size3 mtight"><span class="mord mathnormal mtight" style="margin-right:0.09618em;">J</span></span></span></span><span class="vlist-s"></span></span><span class="vlist-r"><span class="vlist" style="height:0.15em;"><span></span></span></span></span></span></span><span class="mord mathnormal" style="margin-right:0.05764em;">S</span><span class="mord mathnormal" style="margin-right:0.07847em;">I</span><span class="mord mathnormal">G</span><span class="mclose">)</span></span></span></span>(JSIG_DEBUG_CFLAGS) -o <span class="katex"><span class="katex-mathml"><math xmlns="http://www.w3.org/1998/Math/MathML"><semantics><mrow><mi mathvariant="normal">@</mi></mrow><annotation encoding="application/x-tex">@ </annotation></semantics></math></span><span class="katex-html" aria-hidden="true"><span class="base"><span class="strut" style="height:0.6944em;"></span><span class="mord">@</span></span></span></span><
ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) ifeq ($(OS_VENDOR), Darwin) (DSYMUTIL)(DSYMUTIL) (DSYMUTIL)@<span class="katex"><span class="katex-mathml"><math xmlns="http://www.w3.org/1998/Math/MathML"><semantics><mrow><mo stretchy="false">(</mo><mi>L</mi><mi>F</mi><mi>L</mi><mi>A</mi><mi>G</mi><msub><mi>S</mi><mi>J</mi></msub><mi>S</mi><mi>I</mi><mi>G</mi><mo stretchy="false">)</mo></mrow><annotation encoding="application/x-tex">(LFLAGS_JSIG) </annotation></semantics></math></span><span class="katex-html" aria-hidden="true"><span class="base"><span class="strut" style="height:1em;vertical-align:-0.25em;"></span><span class="mopen">(</span><span class="mord mathnormal">L</span><span class="mord mathnormal" style="margin-right:0.13889em;">F</span><span class="mord mathnormal">L</span><span class="mord mathnormal">A</span><span class="mord mathnormal">G</span><span class="mord"><span class="mord mathnormal" style="margin-right:0.05764em;">S</span><span class="msupsub"><span class="vlist-t vlist-t2"><span class="vlist-r"><span class="vlist" style="height:0.3283em;"><span style="top:-2.55em;margin-left:-0.0576em;margin-right:0.05em;"><span class="pstrut" style="height:2.7em;"></span><span class="sizing reset-size6 size3 mtight"><span class="mord mathnormal mtight" style="margin-right:0.09618em;">J</span></span></span></span><span class="vlist-s"></span></span><span class="vlist-r"><span class="vlist" style="height:0.15em;"><span></span></span></span></span></span></span><span class="mord mathnormal" style="margin-right:0.05764em;">S</span><span class="mord mathnormal" style="margin-right:0.07847em;">I</span><span class="mord mathnormal">G</span><span class="mclose">)</span></span></span></span>(JSIG_DEBUG_CFLAGS) <span class="katex"><span class="katex-mathml"><math xmlns="http://www.w3.org/1998/Math/MathML"><semantics><mrow><mo stretchy="false">(</mo><mi>E</mi><mi>X</mi><mi>T</mi><mi>R</mi><msub><mi>A</mi><mi>C</mi></msub><mi>F</mi><mi>L</mi><mi>A</mi><mi>G</mi><mi>S</mi><mo stretchy="false">)</mo><mo>−</mo><mi>o</mi></mrow><annotation encoding="application/x-tex">(EXTRA_CFLAGS) -o </annotation></semantics></math></span><span class="katex-html" aria-hidden="true"><span class="base"><span class="strut" style="height:1em;vertical-align:-0.25em;"></span><span class="mopen">(</span><span class="mord mathnormal" style="margin-right:0.00773em;">EXTR</span><span class="mord"><span class="mord mathnormal">A</span><span class="msupsub"><span class="vlist-t vlist-t2"><span class="vlist-r"><span class="vlist" style="height:0.3283em;"><span style="top:-2.55em;margin-left:0em;margin-right:0.05em;"><span class="pstrut" style="height:2.7em;"></span><span class="sizing reset-size6 size3 mtight"><span class="mord mathnormal mtight" style="margin-right:0.07153em;">C</span></span></span></span><span class="vlist-s"></span></span><span class="vlist-r"><span class="vlist" style="height:0.15em;"><span></span></span></span></span></span></span><span class="mord mathnormal" style="margin-right:0.13889em;">F</span><span class="mord mathnormal">L</span><span class="mord mathnormal">A</span><span class="mord mathnormal" style="margin-right:0.05764em;">GS</span><span class="mclose">)</span><span class="mspace" style="margin-right:0.2222em;"></span><span class="mbin">−</span><span class="mspace" style="margin-right:0.2222em;"></span></span><span class="base"><span class="strut" style="height:0.4306em;"></span><span class="mord mathnormal">o</span></span></span></span>@ $<
/Erik
- Previous message: [8u] Request for Approval and Review: JDK-8136980: build for 8u65 and 8u66 for solaris platforms is failing
- Next message: RFR: JDK-8138692: libjsig compilation is missing EXTRA_CFLAGS on macosx
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]