RFR (XXL): JEP 243: Java-Level JVM Compiler Interface (original) (raw)

Christian Thalinger christian.thalinger at oracle.com
Fri Oct 2 22:43:56 UTC 2015

On Oct 2, 2015, at 12:31 PM, Kim Barrett <kim.barrett at oracle.com> wrote:

On Oct 2, 2015, at 5:04 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:

On Oct 2, 2015, at 10:15 AM, Kim Barrett <kim.barrett at oracle.com> wrote:

On Oct 1, 2015, at 7:46 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:

On Sep 30, 2015, at 3:19 PM, Kim Barrett <kim.barrett at oracle.com> wrote: src/share/vm/gc/shared/cardTableRS.cpp Changes in CardTableRS::verifyspace function.

These don't appear to be specifically related to JVMCI. I'm not sure whether this is someone's debugging code that was left in, or if it might be viewed as an improvement. Either way, I'd prefer that it be a separate change that gets reviewed by folks interested in GC changes, rather than being buried in the JVMCI change set. Removed. Not completely. […] [Note that the removal of the unnecessary (HeapWord*) cast is in there.] But you want me to keep that, right? Yes - just highlighting that this change to keep was intermixed with the stuff to remove. Looks like you did what I wanted, even if I didn’t say it clearly. @@ -344,19 +344,26 @@ assert(jp >= begin && jp < end,_ _errmsg("Error: jp " PTRFORMAT " should be within "_ _"[begin, end) = [" PTRFORMAT "," PTRFORMAT ")",_ _p2i(jp), p2i(begin), p2i(end)));_ _oop obj = oopDesc::loaddecodeheapoop(p);_ _- guarantee(obj == NULL || (HeapWord*)obj >= boundary, - errmsg("pointer " PTRFORMAT " at " PTRFORMAT " on " + if (!(obj == NULL || (HeapWord*)obj >= boundary)) { + tty->printcr("pointer " PTRFORMAT " at " PTRFORMAT " on " "clean card crosses boundary" PTRFORMAT, - p2i((HeapWord*)obj), p2i(jp), p2i(boundary))); + p2i(obj), p2i(jp), p2i(boundary)); +#ifndef PRODUCT + obj->print(); +#endif + haderror = true; + } } public: + bool haderror; + VerifyCleanCardClosure(HeapWord* b, HeapWord* begin, HeapWord* end) : - boundary(b), begin(begin), end(end) { + boundary(b), begin(begin), end(end), haderror(false) { assert(b <= begin, errmsg("Error: boundary " PTRFORMAT " should be at or below begin " PTRFORMAT, p2i(b), p2i(begin))); assert(begin <= end, errmsg("Error: begin " PTRFORMAT " should be strictly below end " PTRFORMAT, Sorry, it wasn’t obvious to me that you are also talking about this code. Removed: http://hg.openjdk.java.net/graal/graal-jvmci-9/hotspot/rev/2d707abdbfba Thanks. Sorry for being unclear; when I said “changes to verifyspace” I was including the related changes to the helper closure object. And that addresses the last of my comments.

Thanks.

More information about the hotspot-dev mailing list