RFR(S): 8138733: Fix build: gcc < 4.8 doesn't grok -Wno-format-zero-length added in 8080775 (original) (raw)

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Tue Oct 6 09:11:18 UTC 2015

Hi David,

thanks for reviewing!

I also don't like that dependency, but in case -Wno-format-zero-length is removed, that can be removed, too.

Best regards, Goetz.

-----Original Message----- From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of David Lindholm Sent: Dienstag, 6. Oktober 2015 10:47 To: hotspot-dev at openjdk.java.net Subject: Re: RFR(S): 8138733: Fix build: gcc < 4.8 doesn't grok -Wno-format-zero-length added in 8080775

Goetz,

On 2015-10-06 09:06, Lindenmaier, Goetz wrote:

Hi,

could I please get a review and a sponsor for this change? http://cr.openjdk.java.net/~goetz/webrevs/8138733-warn/webrev.00/

While I don't really like the GCC-dependency in debug.hpp, I understand that it is necessary for older GCCs. Reviewed.

(I'm not an JDK 9 Reviewer).

Thanks, David

Sorry for first posting to the wrong list.

Best regards, Goetz.

-----Original Message----- From: Mikael Gerdin [mailto:mikael.gerdin at oracle.com] Sent: Freitag, 2. Oktober 2015 13:06 To: Lindenmaier, Goetz; hotspot-dev at openjdk.java.net Developers Subject: Re: RFR(S): 8138733: Fix build: gcc < 4.8 doesn't grok -Wno-format-zero-length added in 8080775 Redirecting to hotspot-dev at ... On 2015-10-02 12:58, Lindenmaier, Goetz wrote: Hi,

We appreciate change 8080775 a lot, but it breaks the build with older gcc. They don't know the option -Wno-format-zero-length. To fix this, I only add -Wno-format-zero-length for gcc >= 4.8. For the other gccs, I remove ATTRIBUTEPRINTF from the declaration of reportvmerror(). This is no big deal, as correctness is guaranteed once it's compiled with gcc 4.8. I had to fix one fatal() in the ppc files, too. Please review this change. I please need a sponsor. http://cr.openjdk.java.net/~goetz/webrevs/8138733-warn/webrev.00/ Best regards, Goetz.

More information about the hotspot-dev mailing list