[8u] Request for Approval and Review: JDK-8136980: build for 8u65 and 8u66 for solaris platforms is failing (original) (raw)
Bengt Rutisson bengt.rutisson at oracle.com
Tue Oct 6 10:01:29 UTC 2015
- Previous message: [8u] Request for Approval and Review: JDK-8136980: build for 8u65 and 8u66 for solaris platforms is failing
- Next message: [8u] Request for Approval and Review: JDK-8136980: build for 8u65 and 8u66 for solaris platforms is failing
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Erik,
On 2015-10-05 11:38, Erik Joelsson wrote:
Another friendly bump for an 8u (R)eviewer for this.
Rubber stamped.
(Thanks for walking me through the patch, Erik!)
Bengt
/Erik On 2015-10-01 15:16, Erik Joelsson wrote: Still looking for an official review from 8u reviewer for this. Ideally someone from Hotspot.
/Erik On 2015-09-30 14:43, Erik Joelsson wrote: Hello,
Please approve and review this fix for 8u. My last fix for this issue, JDK-8136691, was not enough. I made a mistake while verifying the fix and the problem is still there. There are more discrepancies between Solaris and the other platform makefiles. The excludeSrc.gmk file is not included anywhere when building on Solaris. The variable SrcFilesEXCLUDE is overwritten in vm.make instead of appended to, so even when including excludeSrc.gmk, it wasn't enough. The other platform specific buildtree.make files also set INCLUDETRACE in the generated makefile. Bug: https://bugs.openjdk.java.net/browse/JDK-8136980 Webrev: http://cr.openjdk.java.net/~erikj/8136980/webrev.hotspot.01/ /Erik
- Previous message: [8u] Request for Approval and Review: JDK-8136980: build for 8u65 and 8u66 for solaris platforms is failing
- Next message: [8u] Request for Approval and Review: JDK-8136980: build for 8u65 and 8u66 for solaris platforms is failing
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]