CLANG special case (original) (raw)
Staffan Larsen staffan.larsen at oracle.com
Tue Oct 6 19:17:46 UTC 2015
- Previous message: RFR: 8138917: Back out of failing change set for 8130681.
- Next message: CLANG special case
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
When we upgraded to clang 6.3, I verified that the problem still existed. See: https://bugs.openjdk.java.net/browse/JDK-8077364 <https://bugs.openjdk.java.net/browse/JDK-8077364> which has pointers to the two tests that fail without the workaround.
/Staffan
On 6 okt 2015, at 17:38, Phil Race <philip.race at oracle.com> wrote:
Ideally hotspot would review this, not build. so it would be helpful if hotspot found an engineer to own the bug :- https://bugs.openjdk.java.net/browse/JDK-8138820 So far as I know this is not tracked under any other bug id. -phil. On 10/06/2015 05:30 AM, Jim Laskey (Oracle) wrote: I’ve updated to El Capitan and, of course, builds fail, and, of course, I modify hotspot/make/bsd/makefiles/gcc.make one more time and… I think this conditional clause should be removed at the very least (commenting to indicate needs investigation), or someone should research and see which version of clang fixes the issues associate with the patch. Since it’s likely that no one has the cycles, please remove the condition.
Cheers, — Jim
diff -r a02911828e48 make/bsd/makefiles/gcc.make --- a/make/bsd/makefiles/gcc.make Wed Sep 30 07:41:36 2015 -0700 +++ b/make/bsd/makefiles/gcc.make Tue Oct 06 09:22:50 2015 -0300 @@ -313,21 +313,13 @@ # Work around some compiler bugs. ifeq ($(USECLANG), true) - # Clang <= 6.1_ _- ifeq ($(shell expr _ _- $(CCVERMAJOR) < 6 | _ _- ( (CCVERMAJOR)=6&(CCVERMAJOR) = 6 & (CCVERMAJOR)=6&(CCVERMINOR) <= 1 ) _ _- ), 1)_ _- OPTCFLAGS/loopTransform.o += $(OPTCFLAGS/NOOPT)_ _- OPTCFLAGS/unsafe.o += -O1_ _- else_ _- (error"UpdatecompilerworkaroundsforClang(error "Update compiler workarounds for Clang (error"UpdatecompilerworkaroundsforClang(CCVERMAJOR).$(CCVERMINOR)") - endif + OPTCFLAGS/loopTransform.o += $(OPTCFLAGS/NOOPT) + OPTCFLAGS/unsafe.o += -O1 else # 6835796. Problem in GCC 4.3.0 with mulnode.o optimized compilation. ifeq ($(shell expr (CCVERMAJOR)=4&(CCVERMAJOR) = 4 & (CCVERMAJOR)=4&(CCVERMINOR) = 3), 1) OPTCFLAGS/mulnode.o += $(OPTCFLAGS/NOOPT) - endif + endif endif # Flags for generating make dependency flags.
- Previous message: RFR: 8138917: Back out of failing change set for 8130681.
- Next message: CLANG special case
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]