RFR (XS) 8139086: Solaris/Sparc slowdebug build fails for memset_with_concurrent_readers.cpp (original) (raw)
Daniel D. Daugherty daniel.daugherty at oracle.com
Thu Oct 8 14:39:29 UTC 2015
- Previous message: RFR (XS) 8139086: Solaris/Sparc slowdebug build fails for memset_with_concurrent_readers.cpp
- Next message: RFR (XS) 8139086: Solaris/Sparc slowdebug build fails for memset_with_concurrent_readers.cpp
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 10/8/15 6:31 AM, Mikael Gerdin wrote:
Hi all,
We recently discovered that slowdebug builds fail on Solaris/SPARC due to an issue with inline assembly in memsetwithconcurrentreaderssparc.cpp After discussions with the C++ compiler team at Oracle it was pointed out to us that the code was incorrect in that it had too few %'s. Actual registers referenced by name must be escaped with %% but it appears that enabling optimization in the Studio compiler disregards that requirement. Bug: https://bugs.openjdk.java.net/browse/JDK-8139086 Webrev: http://cr.openjdk.java.net/~mgerdin/8139086/webrev/
src/cpu/sparc/vm/memset_with_concurrent_readers_sparc.cpp No comments.
I did a quick audit in the above file and didn't see any other SPARC register usage that wasn't properly escaped. However, I'm getting rusty with SPARC assembly so someone else with more recent Task Relevant Experience (TRE) should sanity check this also...
Thumbs up.
Dan
Testing: Building product|fastdebug|slowdebug on Solaris/SPARC. Thanks /Mikael
- Previous message: RFR (XS) 8139086: Solaris/Sparc slowdebug build fails for memset_with_concurrent_readers.cpp
- Next message: RFR (XS) 8139086: Solaris/Sparc slowdebug build fails for memset_with_concurrent_readers.cpp
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]