RFR: 8042893 and 8042894: PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC needs to be removed from source files (original) (raw)
David Lindholm david.lindholm at oracle.com
Fri Oct 9 07:46:52 UTC 2015
- Previous message: RFR: 8042893 and 8042894: PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC needs to be removed from source files
- Next message: RFR: JDK-5108778 Too many instances of java.lang.Boolean created in Java application(hotspot)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Bengt,
Thanks for the review!
/David
On 2015-10-08 08:57, Bengt Rutisson wrote:
Hi David, Nice cleanup! Thanks for doing this! On 2015-10-07 17:39, David Lindholm wrote: Hi,
Please review the following patch that removes PRAGMAFORMATMUTEWARNINGSFORGCC from all source files in HotSpot. It also fixes all compiler warnings caused by format strings that were previously silenced by this pragma. This patch is a joint effort by me and Goetz Lindenmaier. Bug: https://bugs.openjdk.java.net/browse/JDK-8042893 Bug: https://bugs.openjdk.java.net/browse/JDK-8042894 Webrev: http://cr.openjdk.java.net/~david/JDK-8042893-8042894/webrev.00/ I've browsed the webrev. All changes that I looked closer at looks good and I with all the PRAGMAFORMATMUTEWARNINGSFORGCC gone and it still compiles I think it should be fine. Looks good. Bengt
Testing: Passed JPRT
Thanks, David
- Previous message: RFR: 8042893 and 8042894: PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC needs to be removed from source files
- Next message: RFR: JDK-5108778 Too many instances of java.lang.Boolean created in Java application(hotspot)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]