RFR: 8138659: Speed up InstanceKlass subclass discrimination (original) (raw)

Stefan Karlsson stefan.karlsson at oracle.com
Fri Oct 9 15:40:28 UTC 2015

Hi Kim,

On 2015-10-07 18:02, Kim Barrett wrote:

Another round, with some name changes that resulted from discussion with StefanK and Coleen. Also, Coleen convinced me some functions weren't needed.

New full and incremental webrevs: http://cr.openjdk.java.net/~kbarrett/8138659/webrev.02/ http://cr.openjdk.java.net/~kbarrett/8138659/webrev.02.inc/

Looks OK. Reviewed.

As we've discussed offline, this patch changes the type-checking functions from: Klass::oop_is_instance() Klass::oop_is_array() Klass::oop_is_objArray() Klass::oop_is_typeArray() Klass::oop_is_instanceMirror() Klass::oop_is_instanceClassLoader() Klass::oop_is_instanceRef()

to: Klass::oop_is_instance() Klass::oop_is_array() Klass::oop_is_objArray() Klass::oop_is_typeArray() InstanceKlass::is_mirror_instance_klass() InstanceKlass::is_class_loader_instance_klass() InstanceKlass::is_reference_instance_klass() InstanceKlass::is_other_instance_klass()

I would prefer if we could rename the first four functions to: Klass::is_instance_klass() Klass::is_array() Klass::is_obj_array_klass() Klass::is_type_array_klass() InstanceKlass::is_instance_mirror_klass() InstanceKlass::is_instance_class_loader_klass() InstanceKlass::is_instance_ref_klass() InstanceKlass::is_instance_other_klass()

to keep a slightly more consistent naming scheme. But this should be done as a separate RFE.

Thanks, StefanK

More information about the hotspot-dev mailing list