RFR(XS): 8139900: [TESTBUG] Remove G1UpdateBufferSize and InitialBootClassLoaderMetaspaceSize from TestOptionsWithRanges (original) (raw)

gerard ziemski gerard.ziemski at oracle.com
Tue Oct 20 16:38:01 UTC 2015

hi Dmitry,

Thank you very much for looking into this and making the test more robust.

#1 Did you intend to incluse the change in "test/runtime/CommandLine/OptionsValidation/common/optionsvalidation/JVMOptionsUtils.java" removing addTypeDependency()? Can you please explain that code removal?

#2 How sure are we that 780 sec is enough if the arm's tests are still in progress?

cheers

On 10/20/2015 11:06 AM, Dmitry Dmitriev wrote:

Hello,

Please review fix for TestOptionsWithRanges.java test. In this fix I remove two flags("G1UpdateBufferSize", "InitialBootClassLoaderMetaspaceSize") from testing because their maximum value would consume too much memory and take a lot of time. Also I increase timeout value for the test, since number of flags with ranges were increased recently. JBS: https://bugs.openjdk.java.net/browse/JDK-8139900 webrev.00: http://cr.openjdk.java.net/~ddmitriev/8139900/webrev.00/ <http://cr.openjdk.java.net/%7Eddmitriev/8139900/webrev.00/> Testing: ran on all platforms including arm's(test for few arm's are still in progress). Thanks, Dmitry

More information about the hotspot-dev mailing list