RFR: 8140584: nmethod::oops_do_marking_epilogue always runs verification code (original) (raw)

Mikael Gerdin mikael.gerdin at oracle.com
Tue Oct 27 11:45:21 UTC 2015

Hi Stefan,

On 2015-10-27 12:44, Stefan Karlsson wrote:

Hi,

Please review this patch to remove some unnecessary verification code from our product builds. Today, CodeCache::gcepilogue() guards the call to nmethod::verifyooprelocations with DEBUGONLY, while nmethod::oopsdomarkingepilogue doesn't. Since nmethod::verifyooprelocations uses asserts when verifying the relocations, this is just wasted cycles in product builds. This patch adds DEBUGONLY to nmethod::oopsdomarkingepilogue. http://cr.openjdk.java.net/~stefank/8140584/webrev.01/

Looks good. Thanks for fixing this oversight. /Mikael

https://bugs.openjdk.java.net/browse/JDK-8140584

Thanks, StefanK

More information about the hotspot-dev mailing list