RFR: 8140584: nmethod::oops_do_marking_epilogue always runs verification code (original) (raw)

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Oct 27 15:22:09 UTC 2015

CodeCache::verify_oops() also calls it unguarded.

I think for complete solution nmethod::verify_oop_relocations() and called from it oop_Relocation::verify_oop_relocation(), verify_value(), const_verify_data_value() and pd_verify_data_value() should be declared and defined in debug build only.

Thanks, Vladimir

On 10/27/15 7:44 PM, Stefan Karlsson wrote:

Hi,

Please review this patch to remove some unnecessary verification code from our product builds. Today, CodeCache::gcepilogue() guards the call to nmethod::verifyooprelocations with DEBUGONLY, while nmethod::oopsdomarkingepilogue doesn't. Since nmethod::verifyooprelocations uses asserts when verifying the relocations, this is just wasted cycles in product builds. This patch adds DEBUGONLY to nmethod::oopsdomarkingepilogue. http://cr.openjdk.java.net/~stefank/8140584/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8140584 Thanks, StefanK

More information about the hotspot-dev mailing list