RFR (M) 8055283: Expand ResourceHashtable with C_HEAP allocation, removal and some unit tests (original) (raw)
Thomas Schatzl thomas.schatzl at oracle.com
Wed Oct 28 09:11:57 UTC 2015
- Previous message: RFR (M) 8055283: Expand ResourceHashtable with C_HEAP allocation, removal and some unit tests
- Next message: [patch] correctly detect 32bit platforms
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Mikael,
On Wed, 2015-10-28 at 08:38 +0100, Mikael Gerdin wrote:
Hi Coleen,
On 2015-10-27 15:54, Coleen Phillimore wrote: > > Hi Mikael, This looks fine. Thanks. > > I think it's #ifndef PRODUCT that you should use to wrap the unit test > code. I see, I looked at the block in jni.cpp and you are right. It's a bit weird though since most of the actual tests use assert() which of course is ifdef ASSERT. Anyway, I've changed it as per your request. > > Could you also put some string above it that it's a unit test? Like in > chunkedList.cpp? > > /////////////// Unit tests /////////////// Sure, no problem. Incremental webrev at: http://cr.openjdk.java.net/~mgerdin/8055283/webrev.1to2/ Full webrev at: http://cr.openjdk.java.net/~mgerdin/8055283/webrev.2
still looks good :)
Thomas
- Previous message: RFR (M) 8055283: Expand ResourceHashtable with C_HEAP allocation, removal and some unit tests
- Next message: [patch] correctly detect 32bit platforms
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]