[8u] Request for Approval and Review: JDK-8136691: 8u65/8u66 b14 Solaris builds failed on Linking libverify.so (original) (raw)
Erik Joelsson erik.joelsson at oracle.com
Fri Sep 18 16:41:25 UTC 2015
- Previous message: RFR (S) - 8065155 Refactor Hotspot mapfiles
- Next message: [8u] Request for Approval and Review: JDK-8136691: 8u65/8u66 b14 Solaris builds failed on Linking libverify.so
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hello,
Please approve and review this fix for 8u. There is a discrepancy between the Solaris and Linux makefiles for Hotspot, where a source file is excluded for a certain configuration on Linux but not on Solaris. This causes the build to fail on Solaris in that configuration.
Bug: https://bugs.openjdk.java.net/browse/JDK-8136691
Patch:
diff --git a/make/solaris/makefiles/trace.make
b/make/solaris/makefiles/trace.make
--- a/make/solaris/makefiles/trace.make
+++ b/make/solaris/makefiles/trace.make
@@ -56,8 +56,12 @@
ifeq ($(HAS_ALT_SRC), true)
TraceGeneratedNames +=
traceRequestables.hpp \
- traceEventControl.hpp \
- traceProducer.cpp
traceEventControl.hpp
+ifneq ($(INCLUDE_TRACE), false)
TraceGeneratedNames += traceProducer.cpp +endif
endif
TraceGeneratedFiles = (TraceGeneratedNames:(TraceGeneratedNames:%=(TraceGeneratedNames:(TraceOutDir)/%)
/Erik
- Previous message: RFR (S) - 8065155 Refactor Hotspot mapfiles
- Next message: [8u] Request for Approval and Review: JDK-8136691: 8u65/8u66 b14 Solaris builds failed on Linking libverify.so
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]