RFR (XXL): JEP 243: Java-Level JVM Compiler Interface (original) (raw)
Christian Thalinger christian.thalinger at oracle.com
Mon Sep 21 17:25:31 UTC 2015
- Previous message: RFR (XXL): JEP 243: Java-Level JVM Compiler Interface
- Next message: RFR (XXL): JEP 243: Java-Level JVM Compiler Interface
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Sep 18, 2015, at 7:02 AM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
On Sep 18, 2015, at 1:14 AM, Roland Westrelin <roland.westrelin at oracle.com> wrote:
http://cr.openjdk.java.net/~kvn/JVMCI/webrev.hotspot/ <http://cr.openjdk.java.net/~kvn/JVMCI/webrev.hotspot/> sharedRuntime.cpp 539 if (!((NativeInstruction*)pc)->issafepointpoll()) { 540 tty->printcr("bad pc: %p", pc); 541 Disassembler::decode(cb); 542 assert(false, "Only polling locations are used for safepoint"); 543 } Shouldn’t that be under #idef ASSERT? Either that or make the assert a fatal.
Or both :-)
http://hg.openjdk.java.net/graal/graal-jvmci-9/hotspot/rev/7274d7abdd37 <http://hg.openjdk.java.net/graal/graal-jvmci-9/hotspot/rev/7274d7abdd37>
I looked at the c++ files except src/share/vm/gc stuff. I didn’t go over the java files or makefile changes. What I looked at is ok. Thank you. Roland.
- Previous message: RFR (XXL): JEP 243: Java-Level JVM Compiler Interface
- Next message: RFR (XXL): JEP 243: Java-Level JVM Compiler Interface
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]