RFR: 8080775: Better argument formatting for assert() and friends (original) (raw)
David Lindholm david.lindholm at oracle.com
Tue Sep 29 09:24:32 UTC 2015
- Previous message: RFR: 8080775: Better argument formatting for assert() and friends
- Next message: RFR: 8080775: Better argument formatting for assert() and friends
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Kim,
Thank you for the review!
/David
On 2015-09-28 19:11, Kim Barrett wrote:
On Sep 28, 2015, at 11:37 AM, David Lindholm <david.lindholm at oracle.com> wrote:
Kim and Per,
Thank you! I have made fixes for all your comments, the latest webrev is available here: http://cr.openjdk.java.net/~david/JDK-8080775/webrev.03/ Kim, I have left the casts in the code, as you say this should be fixed in another change. ------------------------------------------------------------------------------ src/share/vm/gc/g1/g1BlockOffsetTable.cpp 364 assert((array->offsetarray(origindex) == 0 && 365 blkstart == boundary) || 366 (array->offsetarray(origindex) > 0 && 367 array->offsetarray(origindex) <= Nwords),_ _Indentation of 366 and 367 are wrong._ _webrev.03 has_ _364 assert((array->offsetarray(origindex) == 0 && 365 blkstart == boundary) || 366 (array->offsetarray(origindex) > 0 && 367 array->offsetarray(origindex) <= Nwords), Lines 365 and 367 should be indented one more space. ------------------------------------------------------------------------------ Otherwise, looks good. I don't need a new webrev for the above.
- Previous message: RFR: 8080775: Better argument formatting for assert() and friends
- Next message: RFR: 8080775: Better argument formatting for assert() and friends
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]