RFR (XS) 8078295 - hotspot test_env.sh can set VM_CPU incorrectly (original) (raw)

Dean Long dean.long at oracle.com
Wed Sep 30 18:55:06 UTC 2015

Looks fine to me, as long as the new output line

115 echo "INT_VERSION=cat vm_version.out 2>&1"

isn't going to confuse any scripts.

dl

On 9/29/2015 12:18 PM, Ioi Lam wrote:

Please review a very small fix:

http://cr.openjdk.java.net/~iklam/8078295testenvsh.01/ Bug: [TESTBUG] hotspot testenv.sh can set VMCPU incorrectly https://bugs.openjdk.java.net/browse/JDK-8078295 Summary of fix: testenv.sh uses the following to get information such as VMCPU ${TESTJAVA}${FS}bin${FS}java ${TESTOPTS} -Xinternalversion > vmversion.out 2>&1 VMCPU="unknown" grep "arm" vmversion.out > ${NULL} if [ $? = 0 ] then VMCPU="arm" fi However, the internal version may contain arbitrary text (from the user name and pwd) such as "arm", which would cause VMCPU to have incorrect value. The fix is to filter out the arbitrary text using a sed script (please see the bug report for details and sample output): _${TESTJAVA}${FS}bin${FS}java ${TESTOPTS} -Xinternalversion _ _| sed -e 's/[(][^)][)]//g' -e 's/ by "[^"]"//g' _ > vmversion.out 2>&1 Tests: JPRT RBT, with the following tests hotspot/test/:hotspotall vm.parallelclassloading.testlist vm.regression.testlist vm.runtime.testlist vm.tmtools.testlist) Thanks - Ioi

More information about the hotspot-dev mailing list