RFR: 8166188: G1 Needs pre barrier on dereference of weak JNI handles (original) (raw)
Kim Barrett kim.barrett at oracle.com
Tue Feb 7 22:29:22 UTC 2017
- Previous message: RFR: 8166188: G1 Needs pre barrier on dereference of weak JNI handles
- Next message: RFR: 8166188: G1 Needs pre barrier on dereference of weak JNI handles
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Feb 7, 2017, at 8:59 AM, Doerr, Martin <martin.doerr at sap.com> wrote:
Hi Kim, thanks for adding and adapting my code. There's only one minor bug on PPC64. Please use the correct label name for the conditional branch as shown in the diff below. If you like, you can add simonis and mdoerr as contributors, but I don't insist on it. I guess SignatureChekker was written with "kk" to distinguish it from something else? Besides that, the change looks good to me. Thanks and best regards, Martin
--- a/src/cpu/ppc/vm/sharedRuntimeppc.cpp Tue Feb 07 12:48:05 2017 +0100 +++ b/src/cpu/ppc/vm/sharedRuntimeppc.cpp Tue Feb 07 14:30:48 2017 +0100 @@ -2483,7 +2483,7 @@ if (rettype == TOBJECT || rettype == TARRAY) { Label done, notweak; __ cmpdi(CCR0, R3RET, 0);_ - _ beq(CCR0, nullresult); // Use NULL as-is. + _ beq(CCR0, done); // Use NULL as-is. __ andi(rtemp1, R3RET, JNIHandles::weaktagmask);_ __ beq(CCR0, notweak); // Test for jweak tag._
Oops. Thanks for the fix.
And thanks for the review.
- Previous message: RFR: 8166188: G1 Needs pre barrier on dereference of weak JNI handles
- Next message: RFR: 8166188: G1 Needs pre barrier on dereference of weak JNI handles
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]