TRACESPINNING in taskqueue.hpp (original) (raw)

David Holmes david.holmes at oracle.com
Wed Feb 15 01:59:44 UTC 2017

On 15/02/2017 4:45 AM, Thomas Schatzl wrote:

Hi Yumin,

On Tue, 2017-02-14 at 08:43 -0800, yumin qi wrote: Hi,

In file taskqueue.hpp, first #undef TRACESPINNING The next whatever in #ifdef TRACESPINNING will not be included in build. Any comment? not sure what you are asking here. Apparently anyone interested in using this code is supposed to change the #undef to #define. Similar to other performance debug code in hotspot.

Right ... except there's really no reason to have the undef unless TRACESPINNING is normally set by the build - which it isn't. It would be marginally more developer friendly to just be able to add -DTRACESPINNING to the make args than having to edit the file first.

Cheers, David

Thanks, Thomas

More information about the hotspot-dev mailing list