RFR: 8168914: Crash in ClassLoaderData/JNIHandleBlock::oops_do during concurrent marking (original) (raw)

Thomas Schatzl thomas.schatzl at oracle.com
Wed Feb 15 15:28:48 UTC 2017

Hi,

On Wed, 2017-02-15 at 16:07 +0100, Erik Helin wrote:

On 02/15/2017 02:48 AM, David Holmes wrote: > > Hi Erik, Hi David,

thanks for having a look! Please see new patches at: - incremental: http://cr.openjdk.java.net/~ehelin/8168914/00-01/ - full: http://cr.openjdk.java.net/~ehelin/8168914/01/

http://cr.openjdk.java.net/~ehelin/8168914/01/src/share/vm/classfile/cl assLoaderData.hpp.frames.html  177     // Only one thread can add a time, guarded by the Metaspace_lock.

-> Only one thread can add elements at a time, ...

Also, I would somewhat prefer if the method actually asserted that Metaspace_lock is owned by this thread if it has been explicitly mentioned in the description.

 - same file:

 211   ChunkedHandleList _handles; // Handles to constant pool arrays, Modules, etc, which  212                               // have the same life cycle of the corresponding ClassLoader.

-> ... have the same life cycle as the corresponding class loader.

Looks good otherwise. I do not need a re-review for the comment changes.

Thanks,   Thomas

More information about the hotspot-dev mailing list