RFR: 8166188: G1 Needs pre barrier on dereference of weak JNI handles (original) (raw)

Kim Barrett kim.barrett at oracle.com
Wed Feb 15 19:47:43 UTC 2017

On Feb 15, 2017, at 11:34 AM, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:

On 2/12/17 9:25 PM, Kim Barrett wrote: Here's the updated webrevs, incorporating feedback received so far.

full: http://cr.openjdk.java.net/~kbarrett/8166188/hotspot.05/

Thanks Dan.

src/share/vm/runtime/javaCalls.hpp No comments. src/share/vm/runtime/javaCalls.cpp No comments. src/share/vm/runtime/jniHandles.hpp No comments. src/share/vm/runtime/jniHandles.cpp No comments. src/share/vm/prims/jni.cpp No comments. src/share/vm/prims/jvmtiEnv.cpp No comments. make/test/JtregNative.gmk No comments. src/cpu/aarch64/vm/sharedRuntimeaarch64.cpp No comments. src/cpu/aarch64/vm/templateInterpreterGeneratoraarch64.cpp No comments. src/cpu/arm/vm/interpmasmarm.cpp No comments. src/cpu/arm/vm/interpmasmarm.hpp No comments. src/cpu/arm/vm/macroAssemblerarm.cpp No comments. src/cpu/arm/vm/macroAssemblerarm.hpp No comments. src/cpu/arm/vm/sharedRuntimearm.cpp No comments. src/cpu/arm/vm/templateInterpreterGeneratorarm.cpp No comments. src/cpu/ppc/vm/frameppc.cpp No comments. src/cpu/ppc/vm/sharedRuntimeppc.cpp No comments. src/cpu/ppc/vm/templateInterpreterGeneratorppc.cpp No comments. src/cpu/s390/vm/sharedRuntimes390.cpp No comments. src/cpu/s390/vm/templateInterpreterGenerators390.cpp No comments. src/cpu/sparc/vm/sharedRuntimesparc.cpp No comments. src/cpu/sparc/vm/templateInterpreterGeneratorsparc.cpp No comments. src/cpu/x86/vm/macroAssemblerx86.cpp No comments. src/cpu/x86/vm/macroAssemblerx86.hpp No comments. src/cpu/x86/vm/sharedRuntimex8632.cpp No comments. src/cpu/x86/vm/sharedRuntimex8664.cpp No comments. src/cpu/x86/vm/templateInterpreterGeneratorx86.cpp No comments. src/cpu/zero/vm/cppInterpreterzero.cpp No comments. src/share/vm/shark/sharkNativeWrapper.cpp No comments. test/runtime/jni/CallWithJNIWeak/CallWithJNIWeak.java No comments. test/runtime/jni/CallWithJNIWeak/libCallWithJNIWeak.c No comments. test/runtime/jni/ReturnJNIWeak/ReturnJNIWeak.java No comments. test/runtime/jni/ReturnJNIWeak/libReturnJNIWeak.c No comments. Thumbs up! Dan

incr: http://cr.openjdk.java.net/~kbarrett/8166188/hotspot.05.inc/ For x86 and ARM I added resolvejobject functions to their respective macroAssembler files, and call those to generate the return object handling code. Merging the two cases for Sparc is harder and I'm going to leave it to someone else. I'm also leaving any such merging for other (non-Oracle) ports to their respective maintainers. Rewrote the error checking in SignatureChekker::checkobj to simplify the control flow and provide more information. Rather than conditionally selecting between ReportJNIFatalError or assert to report problems, instead just always use guarantee. Recall that we only get here if CheckJNICalls or in a debug build. This made SignatureChekker::thread unused, so removed it.

More information about the hotspot-dev mailing list