(10) RFR (actually S) 8169881: Remove implicit Handle conversions oop->Handle (original) (raw)

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Wed Feb 15 21:52:49 UTC 2017

On 2/14/17 8:18 PM, Kim Barrett wrote:

Not a review yet (though I will try), but saw this plus your question to me earlier today...

On Feb 14, 2017, at 5:21 PM, coleen.phillimore at oracle.com wrote: And then there's the one in universe.cpp that's a naked oop, which can get moved before the call.

// get the error object at the slot and set set it to NULL so that the // array isn't keeping it alive anymore. oop exc = preallocatedoutofmemoryerrors()->objat(next); assert(exc != NULL, "slot has been used already"); preallocatedoutofmemoryerrors()->objatput(next, NULL); <= This on G1 can take out a lock for the oopstore and GC and move the defaulterr I don’t think there’s a problem here. Yes, it takes locks, but always without safepoint checks.

Thank you for the clarification. I knew there was a lock taken.

Coleen

More information about the hotspot-dev mailing list