RFR(S): 8176102 - Rename hotspot_fast* test groups to hotspot_tier1* (original) (raw)

Christian Tornqvist christian.tornqvist at oracle.com
Tue Mar 7 16:24:05 UTC 2017

I'm going to go ahead and push this change, the compiler team can follow up on the renaming of hotspot_not_fast_compiler at a later time.

Thanks, Christian

-----Original Message----- From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Christian Tornqvist Sent: Monday, March 6, 2017 4:24 PM To: 'Vladimir Kozlov' <vladimir.kozlov at oracle.com>; 'David Holmes' <david.holmes at oracle.com>; hotspot-dev at openjdk.java.net Subject: RE: RFR(S): 8176102 - Rename hotspot_fast* test groups to hotspot_tier1*

Hi Vladimir,

That would be misleading though, it's used a lot more than just in tier2.

Thanks, Christian

-----Original Message----- From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com] Sent: Monday, March 6, 2017 11:59 AM To: Christian Tornqvist <christian.tornqvist at oracle.com>; 'David Holmes' <david.holmes at oracle.com>; hotspot-dev at openjdk.java.net Subject: Re: RFR(S): 8176102 - Rename hotspot_fast* test groups to hotspot_tier1*

Hi Christian,

As I remember hotspot_not_fast_compiler is used in later tiers. Can we just name it accordingly, for example: hotspot_tier2_compiler?

Thanks, Vladimir

On 3/6/17 7:36 AM, Christian Tornqvist wrote:

Hi David,

Not sure what that name would be though, the compiler is using this group with flag rotation in multiple tiers. I'll leave the renaming of this group to the compiler team to sort out. Thanks, Christioan -----Original Message----- From: David Holmes [mailto:david.holmes at oracle.com] Sent: Friday, March 3, 2017 9:21 PM To: Christian Tornqvist <christian.tornqvist at oracle.com>; hotspot-dev at openjdk.java.net Subject: Re: RFR(S): 8176102 - Rename hotspotfast* test groups to hotspottier1* Hi Christian, Rename looks good. Should we also rename the now oddly named hotspotnotfastcompiler? Thanks, David On 4/03/2017 1:41 AM, Christian Tornqvist wrote: Hi everyone,

Please review this small change that renames the hotspotfast* test groups to hotspottier1, also renamed the hotspotruntimetier* to follow the same naming standard. Tested by running the change through JPRT. Webrevs: http://cr.openjdk.java.net/~ctornqvi/webrev/8176102/root/webrev.00/ http://cr.openjdk.java.net/~ctornqvi/webrev/8176102/hotspot/webrev.00 / Bug: https://bugs.openjdk.java.net/browse/JDK-8176102 Thanks, Christian

More information about the hotspot-dev mailing list