JDK10/RFR(XXS): 8011352: C1: TraceCodeBlobStacks crashes fastdebug solaris sparc (original) (raw)
Rickard Bäckman rickard.backman at oracle.com
Thu Mar 23 14:04:57 UTC 2017
- Previous message: JDK10/RFR(XXS): 8011352: C1: TraceCodeBlobStacks crashes fastdebug solaris sparc
- Next message: Request for clarification about changes in Hotspot across 8, 9, and 10
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks good.
/R
On 03/23, Patric Hedlin wrote:
Hi,
Please review this minor change/fix: https://bugs.openjdk.java.net/browse/JDK-8011352 Rationale: Replacing assumption on 'youngerwindow' being available when performing lookup on OUT-register part (in window), in order to handle such access in the same manner as other "out-of-scope" lookup (i.e. by returning NULL). Regards, Patric Patch below: -----8<-----_ _--- old/src/cpu/sparc/vm/framesparc.cpp Wed Mar 22 16:47:13 2017_ _+++ new/src/cpu/sparc/vm/framesparc.cpp Wed Mar 22 16:47:12 2017_ _@@ -123,8 +123,8 @@_ _reg = regname->asRegister(); } if (reg->isout()) { - assert(youngerwindow != NULL, "Younger window should be available"); - return secondword + (address)&youngerwindow[reg->aftersave()->spoffsetinsavedwindow()]; + return youngerwindow == NULL ? NULL : + secondword + (address)&youngerwindow[reg->aftersave()->spoffsetinsavedwindow()]; } if (reg->islocal() || reg->isin()) { assert(window != NULL, "Window should be available");
- Previous message: JDK10/RFR(XXS): 8011352: C1: TraceCodeBlobStacks crashes fastdebug solaris sparc
- Next message: Request for clarification about changes in Hotspot across 8, 9, and 10
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]