RFR(S) : 8177374 : fix module dependency declaration in jdk_svc tests (original) (raw)

Igor Ignatyev igor.ignatyev at oracle.com
Thu Mar 23 20:07:42 UTC 2017

Mandy/Daniel,

yes, jdk.management.agent does require java.management, but not transitively. Shura and I have discussed that and agreed that in such cases a test should declare dependency explicitly, otherwise it can start to fail when some of transitive requires (which are not a part of the contract) are changed.

I used jdeps with the post-proceccing which makes reduction similar to list-reduced-deps. I have run 'jdeps --list-reduced-deps' on classes from sun/management/jmxremote/bootstrap/CustomLauncherTest.java test run, and it showed the same:

java.management jdk.attach jdk.management.agent/jdk.internal.agent unnamed module: /tmp/run/jdk/sun/management/jmxremote/bootstrap/JTwork-sun-management-jmxremote-bootstrap-CustomLauncherTest-java0/classes

Thanks, -- Igor

On Mar 23, 2017, at 9:39 AM, Mandy Chung <mandy.chung at oracle.com> wrote:

On Mar 23, 2017, at 7:33 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote: Hi Igor, small nit: 42 * @modules java.management 43 * jdk.attach 44 * jdk.management.agent/jdk.internal.agent I don't think java.management needs to be specified as a dependency when the test requires jdk.management.agent, because jdk.management.agent already requires java.management. That’s true. Igor - How do you analyze the dependency? Are you using jdeps —-list-reduced-deps? Mandy

More information about the hotspot-dev mailing list