RFR(M) : 8177507 : line number sensitive tests for jdi should be unified (original) (raw)

Igor Ignatyev igor.ignatyev at oracle.com
Wed Mar 29 02:50:22 UTC 2017

Hi David,

thank you for review. please see my answers inlined.

On Mar 28, 2017, at 6:37 PM, David Holmes <david.holmes at oracle.com> wrote:

Hi Igor, This cleanup looks good to me! One query: test/com/sun/jdi/LineNumberOnBraceTest.java The old version seems to have the wrong line numbers - was it failing? it didn't run, because it had @test/nodynamiccopyright/ instead of @test Two nits: - test/com/sun/jdi/FetchLocals.java - test/com/sun/jdi/LambdaBreakpointTest.java Second copyright year should be 2017. sure, I'll update it before push.

-- Igor

Thanks, David ----- On 29/03/2017 10:42 AM, Igor Ignatyev wrote: Hi,

still looking for a reviewer, anyone? -- Igor On Mar 24, 2017, at 1:56 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:

http://cr.openjdk.java.net/~iignatyev/8177507/webrev.00 295 lines changed: 176 ins; 15 del; 104 mod; Hi all, could you please review this fix for 8177507? due to their nature, some of jdi tests are line number sensitive. unfortunately different tests indicate that differently, so it's quite easy to overlook that and incidentally break tests, for example by changing module dependency declaration or license modification. this fix unifies the way line number sensitivity is indicated and also improves readability/maintainability of some tests by using constant fields instead of magic numbers. some of line number sensitive tests have been unexpectedly removed from execution because they had @test/nodynamiccopyright/ instead of @test tag. this changeset fixes and returns them to regular execution. webrev: http://cr.openjdk.java.net/~iignatyev/8177507/webrev.00 JBS: https://bugs.openjdk.java.net/browse/JDK-8177507 testing: test/com/sun/jdi Thanks, -- Igor

More information about the hotspot-dev mailing list