RFR: 8179444: AArch64: Put zero_words on a diet (original) (raw)

Andrew Haley aph at redhat.com
Fri May 5 15:06:51 UTC 2017

On 05/05/17 10:47, Andrew Dinn wrote:

On 03/05/17 18:05, Andrew Haley wrote:

New version, corrected: . . . http://cr.openjdk.java.net/~aph/8179444-2/

OK? The patch looks good (not an official review) except that I don't understand one detail. Why does MacroAssembler::zerowords include this? + RuntimeAddress zeroblocks = RuntimeAddress(StubRoutines::aarch64::zeroblocks()); + assert(zeroblocks.target() != NULL, "zeroblocks stub has not been generated"); + if (StubRoutines::aarch64::complete()) { + trampolinecall(zeroblocks); + } else { + bl(zeroblocks); + }

Trampoline calls only work from compiler-generated code, so we have to do something different when we're generating the stubs. I suppose I could have had two versions of MacroAssembler::zero_words or added a parameter to say we're generating stubs. Would that be clearer?

Andrew.

More information about the hotspot-dev mailing list