RFR(XXS) : 8180004: jdk.test.lib.DynamicVMOption should be moved to jdk.test.lib.management (original) (raw)
mikhailo mikhailo.seledtsov at oracle.com
Wed May 10 23:11:49 UTC 2017
- Previous message: RFR(XXS) : 8180004: jdk.test.lib.DynamicVMOption should be moved to jdk.test.lib.management
- Next message: RFR(XXS) : 8180183: Confusing javadoc comment to the getOutput(ProcessBuilder processBuilder) method of jdk.test.lib.process.ProcessTools
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks good to me,
Misha
On 05/09/2017 02:05 PM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8180004/webrev.00/index.html
8 lines changed: 1 ins; 0 del; 7 mod; Hi all, could you please review this tiny patch which moves jdk.test.lib.DynamicVMOption class to jdk.test.lib.management package and updates the tests which use it? j.t.l.DynamicVMOption uses classes from jdk.management module, so having it in common testlibrary package might cause redundant module dependencies. webrev: http://cr.openjdk.java.net/~iignatyev//8180004/webrev.00/index.html jbs: https://bugs.openjdk.java.net/browse/JDK-8180004 testing: :hotspotall Thanks, -- Igor
- Previous message: RFR(XXS) : 8180004: jdk.test.lib.DynamicVMOption should be moved to jdk.test.lib.management
- Next message: RFR(XXS) : 8180183: Confusing javadoc comment to the getOutput(ProcessBuilder processBuilder) method of jdk.test.lib.process.ProcessTools
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]