[XS] RFR : 8180945 : vmError.cpp : adjust dup and fclose (original) (raw)

David Holmes david.holmes at oracle.com
Fri May 26 00:47:24 UTC 2017


Hi Matthias,

On 25/05/2017 1:42 AM, Baesken, Matthias wrote:

Hello, could I please have a review for the following small change . In vmError.cpp there is a part where the dup return code in case of an error is not handled, and additionally fclose might be called with parameter NULL .

The fix looks good to me.

I will sponsor this for you. I think this constitutes a trivial fix so I will apply the one Reviewer rule.

Thanks, David

The change adjusts this.

Bug : https://bugs.openjdk.java.net/browse/JDK-8180945 webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8180945/

Thanks, Matthias



More information about the hotspot-dev mailing list