RFR: 8191333: Zero variant broken after 8189941 (original) (raw)

Severin Gehwolf sgehwolf at redhat.com
Thu Nov 16 09:12:46 UTC 2017

On Thu, 2017-11-16 at 08:49 +0100, John Paul Adrian Glaubitz wrote:

On 11/16/2017 08:46 AM, Robbin Ehn wrote: > > > Honestly, after looking at it, I have no idea.  It seems like > > > something you should remove and see if that works.  The comment > > > says that there should be no > > > active handles.  Maybe have a NoHandleMark unconditionally? > > > then SafepointMechanism::blockifrequested(THREAD) so that the > > > comment is actually an assertion. > > > Sorry for too quick review. > > > > I just tested that. This builds fine. Whether it's the way to go, I'm > > not sure. Maybe Robbin can make a statement regarding this. > > Depending on how much testing you have time for, if little time > keep Handle, e.g something like:

It's not so much a matter of time but rather that I unfortunately still haven't understood how to run the testsuite in OpenJDK. It's apparently not as simple as running "make check" but involves configuring external programs.

Add to that, that most basic tests usually expect a client/server JVM for which Zero is an odd ball. Also, due to it's weaker performance many tests time out and fail rather than conditionally setting longer timeout values. It's a rather large and cumbersome process to make the whole test suite Zero compatible.

It's more of a case of going through every test one by one and figuring out whether a "failure" is a test issue, a Zero issue, or an environmental issue.

Thanks, Severin

More information about the hotspot-dev mailing list