RFR: 8187227: __m68k_cmpxchg() is not being used correctly (original) (raw)
Andrew Haley aph at redhat.com
Sat Nov 18 11:46:27 UTC 2017
- Previous message: RFR: 8187227: __m68k_cmpxchg() is not being used correctly
- Next message: RFR: 8187227: __m68k_cmpxchg() is not being used correctly
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi,
On 18/11/17 02:47, David Holmes wrote:
On 18/11/2017 10:36 AM, John Paul Adrian Glaubitz wrote:
Hi!
On m68k, linux-zero has platform-specific implementations for compareandswap(), _addandfetch() and locktestandset(). These functions are all using m68kcmpxchg() which is basically a wrapper around the m68k assembly instruction CAS. Without seeing how that wrapper actually works, it is hard to know whether what you are saying and your fix is correct. The description of the CAS at [1] doesn't help without knowing how it actually gets used.
I can't see the point of the loops.
-- Andrew Haley Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
- Previous message: RFR: 8187227: __m68k_cmpxchg() is not being used correctly
- Next message: RFR: 8187227: __m68k_cmpxchg() is not being used correctly
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]