RFR(XS): 8187280: Remove unused methods from StubQueue (original) (raw)

Volker Simonis volker.simonis at gmail.com
Wed Nov 22 17:15:55 UTC 2017

Hi,

this somehow got lost and you boss is now urging me to finish it before Ramp Down Phase 1 :)

I've rebased it upon the current version of jdk/hs:

http://cr.openjdk.java.net/~simonis/webrevs/2017/8187280.v2/

Besides the usual directory shuffling because of the repo consolidation, the change is still the same.

Can somebody please sponsor this?

Thank you and best regards, Volker

On Wed, Sep 6, 2017 at 10:06 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

Good

Thanks Vladimir

On Sep 6, 2017, at 10:31 AM, Volker Simonis <volker.simonis at gmail.com> wrote:

On Wed, Sep 6, 2017 at 6:14 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote: What about stubcodebegin and stubcodeend?

You're right! Removed them as well: http://cr.openjdk.java.net/~simonis/webrevs/2017/8187280.v1/ Thanks, Volker Thanks Vladimir Sent from my iPhone On Sep 6, 2017, at 7:02 AM, Volker Simonis <volker.simonis at gmail.com> wrote:

Hi, can I please get a review and a sponsor for the following trivial change: http://cr.openjdk.java.net/~simonis/webrevs/2017/8187280/ https://bugs.openjdk.java.net/browse/JDK-8187280

While working on "8166317: InterpreterCodeSize should be computed" I found that several methods on StubQueue are not used any more in the current code base. As StubQueue's code is "more subtle than it looks" (see stubs.cpp) I think it helps to at least remove the unused parts :) Tested by doing a product/slowdebug build and running the hotspot regression tests. Thank you and best regards, Volker

More information about the hotspot-dev mailing list