RFR: 8187227: Zero should use compiler built-ins for atomics on linux-m68k (original) (raw)
Robbin Ehn robbin.ehn at oracle.com
Thu Nov 23 13:38:45 UTC 2017
- Previous message: RFR: 8187227: Zero should use compiler built-ins for atomics on linux-m68k
- Next message: RFR: 8187227: Zero should use compiler built-ins for atomics on linux-m68k
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi, a bit out of scope, mostly for Andrew.
Not sure how old compiler you want to be use but __sync_XXX is 'legacy' since 4.7. So shouldn't we change to __atomic_XXX ?
Manual vaguely says: "They should not be used for new code which should use the ‘__atomic’ builtins instead."
/Robbin
On 2017-11-23 12:16, Andrew Haley wrote:
On 23/11/17 10:21, John Paul Adrian Glaubitz wrote:
Hi!
On 11/21/2017 02:37 PM, John Paul Adrian Glaubitz wrote: I have updated the webrev now accordingly and pushed it to [1].
The build and run-test is currently pending (still building), but since libjvm.so already compiled successfully, I am 99% confident the change is correct as is. Sorry for poking again, but could someone review the change? Yes, that looks fine. I assume you're picking up the compiler builtin for 68k.
- Previous message: RFR: 8187227: Zero should use compiler built-ins for atomics on linux-m68k
- Next message: RFR: 8187227: Zero should use compiler built-ins for atomics on linux-m68k
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]