RFR: 8176717: GC log file handle leaked to child processes (original) (raw)

Per Liden per.liden at oracle.com
Tue Apr 3 07:00:28 UTC 2018

On 03/30/2018 01:16 PM, Thomas Stüfe wrote:

Hi Leo,

looks okay. I stated my reservations against adding this function and the platform specific code in its current form before, but I can certainly live with this fix. It follows what we did in os::open(), so it is consistent in that matter. Thanks for fixing this! Thomas (btw, I am not sure which of my "2" Per meant, since I accidentally miscounted my points in the earlier mail.)

Ah, didn't even notice ;) I was referring to the third bullet (the second "2").

/Per

On Thu, Mar 29, 2018 at 5:41 PM, Leo Korinth <leo.korinth at oracle.com_ _<mailto:leo.korinth at oracle.com>> wrote: On 23/03/18 20:03, Leo Korinth wrote: Hi! Cross-posting this to both hotspot-dev and hotspot-runtime-dev to get more attention. Sorry. Original mail conversation can be found here: http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-March/030637.html <http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-March/030637.html> I need feedback to know how to continue. Thanks, Leo Hi! Below is a new webrev with Thomas' and Per's suggested name change from: os::fopenretain(const char* path, const char* mode) to:   os::fopen(const char* path, const char* mode) Full webrev: http://cr.openjdk.java.net/~lkorinth/8176717/02/ <http://cr.openjdk.java.net/~lkorinth/8176717/02/> Review and/or comments please! Thanks, Leo

More information about the hotspot-dev mailing list