RFR: 8200429: Adjust object pinning interface on CollectedHeap (original) (raw)

Per Liden per.liden at oracle.com
Tue Apr 3 08:37:36 UTC 2018

On 04/03/2018 10:27 AM, Roman Kennke wrote:

Am 03.04.2018 um 08:42 schrieb Per Liden:

The recent additions to CollectedHeap to support object pinning didn't quite fit the bill for what the Shenandoah folks had in mind. Instead of having CollectedHeap::pinobejct/unpinobject grab/release the GCLocker when object pinning is not supported, we add a CollectedHeap::supportsobejctpinning() and let the caller take the appropriate action based on the response.

Bug: https://bugs.openjdk.java.net/browse/JDK-8200429 Webrev: http://cr.openjdk.java.net/~pliden/8200429/webrev.0 /Per Looks good to me. Thank you!

Thanks for reviewing Roman!

Do you or Zhengyu plan on upstreaming a version of the patch you linked to in the other mail thread, to support object pinning with JavaCritical_? It seems that patch would complete the overall object pinning story for HotSpot and would be useful for other GCs as well (at least G1 and ZGC).

/Per

Roman

More information about the hotspot-dev mailing list