RFR(XS): JDK-8199780: SetMemory0 and CopyMemory0 in unsafe.cpp need to resolve their operands (original) (raw)

Roman Kennke rkennke at redhat.com
Tue Apr 3 13:58:08 UTC 2018

Duh. Thanks Zhengyu for spotting this.

Can you please ack this rather trivial change:

Differential: http://cr.openjdk.java.net/~rkennke/JDK-8199780/webrev.02.diff/ Full: http://cr.openjdk.java.net/~rkennke/JDK-8199780/webrev.02/

I re-submitted the same change for testing.

Thanks, Roman

Seems oopDesc::isnull() no longer exists.

-Zhengyu On 04/03/2018 09:34 AM, Roman Kennke wrote: Am 03.04.2018 um 13:59 schrieb Aleksey Shipilev:

On 03/28/2018 03:55 PM, Roman Kennke wrote:

Am 21.03.2018 um 20:18 schrieb Roman Kennke:

Diff: http://cr.openjdk.java.net/~rkennke/JDK-8199780/webrev.01.diff/ Full: http://cr.openjdk.java.net/~rkennke/JDK-8199780/webrev.01/ Looks good. -Aleksey Thanks Aleksey! Unfortunately, testing came back with UNSTABLE, but it doesn't look like related to this change (see below). Can somebody advice me what to do? Thanks, Roman Build Details: 2018-04-03-1240382.roman.source 0 Failed Tests Mach5 Tasks Results Summary EXECUTEDWITHFAILURE: 14 KILLED: 0 NA: 0 UNABLETORUN: 69 PASSED: 0 FAILED: 0 Build 14 Not run buildjdklinux-linux-x64-linux-x64-build-0 error while building, return value: 2 buildjdklinux-linux-x64-debug-linux-x64-build-1 error while building, return value: 2 buildjdklinux-linux-x64-open-linux-x64-build-2 error while building, return value: 2 buildjdklinux-linux-x64-open-debug-linux-x64-build-3 error while building, return value: 2 buildjdkmacosx-macosx-x64-macosx-x64-build-4 error while building, return value: 2 buildjdkmacosx-macosx-x64-debug-macosx-x64-build-5 error while building, return value: 2 buildjdkmacosx-macosx-x64-open-macosx-x64-build-6 error while building, return value: 2 buildjdkmacosx-macosx-x64-open-debug-macosx-x64-build-7 error while building, return value: 2 buildjdksolaris-solaris-sparcv9-solaris-sparcv9-build-8 error while building, return value: 2 buildjdksolaris-solaris-sparcv9-debug-solaris-sparcv9-build-9 error while building, return value: 2 See all 14... Test 69 Not run tier1-product-jdkclosedtesthotspotjtregtier1common-linux-x64-20 Dependency task failed: mach5...8-buildjdklinux-linux-x64-linux-x64-build-0 tier1-debug-jdkclosedtesthotspotjtregtier1common-linux-x64-debug-56 Dependency task failed: mach5...djdklinux-linux-x64-debug-linux-x64-build-1 tier1-product-jdkclosedtesthotspotjtregtier1common-macosx-x64-21 Dependency task failed: mach5...uildjdkmacosx-macosx-x64-macosx-x64-build-4 tier1-debug-jdkclosedtesthotspotjtregtier1common-macosx-x64-debug-57 Dependency task failed: mach5...dkmacosx-macosx-x64-debug-macosx-x64-build-5 tier1-solaris-sparc-jdkclosedtesthotspotjtregtier1common-solaris-sparcv9-70 Dependency task failed: mach5...laris-solaris-sparcv9-solaris-sparcv9-build-8 tier1-solaris-sparc-jdkclosedtesthotspotjtregtier1common-solaris-sparcv9-debug-71 Dependency task failed: mach5...solaris-sparcv9-debug-solaris-sparcv9-build-9 tier1-product-jdkclosedtesthotspotjtregtier1common-windows-x64-22 Dependency task failed: mM15jYAzw tier1-debug-jdkclosedtesthotspotjtregtier1common-windows-x64-debug-58 Dependency task failed: mM15jYAAw tier1-debug-jdkclosedtesthotspotjtregtier1compilerclosed-linux-x64-debug-59 Dependency task failed: mach5...djdklinux-linux-x64-debug-linux-x64-build-1 tier1-debug-jdkclosedtesthotspotjtregtier1compilerclosed-macosx-x64-debug-60 Dependency task failed: mach5...dkmacosx-macosx-x64-debug-macosx-x64-build-5 See all 69...

More information about the hotspot-dev mailing list