RFR (XS): 8201167: Remove MacroAssembler::cmp_heap_oop on x86 (original) (raw)
Erik Österlund erik.osterlund at oracle.com
Thu Apr 5 08:25:12 UTC 2018
- Previous message: RFR (XS): 8201167: Remove MacroAssembler::cmp_heap_oop on x86
- Next message: RFR: 8201168: Move GC command line constraint functions to GC specific files
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Thomas,
Thanks for the review.
/Erik
On 2018-04-05 10:22, Thomas Schatzl wrote:
Hi,
On Thu, 2018-04-05 at 10:09 +0200, Erik Österlund wrote: Hi,
The MacroAssembler::cmpheapoop member function on x86 is not currently used anywhere in hotspot. Moreover, it is no longer safe to use it with modern GCs using load barriers. Since it is unsafe to use and is not used today, it should be removed. Webrev: http://cr.openjdk.java.net/~eosterlund/8201167/webrev.00/ Thanks, /Erik looks good. Thomas
- Previous message: RFR (XS): 8201167: Remove MacroAssembler::cmp_heap_oop on x86
- Next message: RFR: 8201168: Move GC command line constraint functions to GC specific files
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]