RFR: 8201136: Move GC flags from globals.hpp to GC specific files (original) (raw)
Robbin Ehn robbin.ehn at oracle.com
Thu Apr 5 09:26:49 UTC 2018
- Previous message: RFR: 8201136: Move GC flags from globals.hpp to GC specific files
- Next message: RFR: 8201136: Move GC flags from globals.hpp to GC specific files
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 2018-04-05 11:04, Aleksey Shipilev wrote:
On 04/05/2018 08:11 AM, Stefan Karlsson wrote:
Please review this patch to move GC flags out of globals.hpp and into GC specific files.
http://cr.openjdk.java.net/~stefank/8201136/webrev.01 https://bugs.openjdk.java.net/browse/JDK-8201136 Oooof, what a move! I like it, looks good.
+1
/Robbin
*) In globals.hpp, L2987-..., you probably want to right-adjust the backslashes? *) In gcglobals.hpp, we still have Use{CMS,Serial,G1,Parallel,...}GC -- is the intent to have these in shared gcglobals.hpp, not in per-GC-globals.hpp, and check for GC support at init? In other words, when conditional GC compilation arrives, we still have GC enabling flags available, but not the GC-specific flags? Thanks, -Aleksey
- Previous message: RFR: 8201136: Move GC flags from globals.hpp to GC specific files
- Next message: RFR: 8201136: Move GC flags from globals.hpp to GC specific files
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]