RFR: 8201136: Move GC flags from globals.hpp to GC specific files (original) (raw)

Stefan Karlsson stefan.karlsson at oracle.com
Thu Apr 5 09:58:03 UTC 2018

On 2018-04-05 11:04, Aleksey Shipilev wrote:

On 04/05/2018 08:11 AM, Stefan Karlsson wrote:

Please review this patch to move GC flags out of globals.hpp and into GC specific files.

 http://cr.openjdk.java.net/~stefank/8201136/webrev.01  https://bugs.openjdk.java.net/browse/JDK-8201136 Oooof, what a move! I like it, looks good.

Thanks, Aleksey.

*) In globals.hpp, L2987-..., you probably want to right-adjust the backslashes?

I sent an updated webrev to my answer to StefanJ's review. I hope that looks good enough.

*) In gcglobals.hpp, we still have Use{CMS,Serial,G1,Parallel,...}GC -- is the intent to have these in shared gcglobals.hpp, not in per-GC-globals.hpp, and check for GC support at init? In other words, when conditional GC compilation arrives, we still have GC enabling flags available, but not the GC-specific flags?

The current state of my patch guards most usages of the Use{CMS,Serial,G1,Parallel,...}GC flags with the appropriate INCLUDE_ guard. I'm not sure if it is possible to take it all the way and guard all usages, but I try and we'll see if it is possible.

What do you think? Should we try to move the flags to their respective _globals.hpp file?

Thanks, StefanK

Thanks, -Aleksey

More information about the hotspot-dev mailing list