RFR: 8201136: Move GC flags from globals.hpp to GC specific files (original) (raw)
Stefan Johansson stefan.johansson at oracle.com
Thu Apr 5 11:45:21 UTC 2018
- Previous message: RFR: 8201136: Move GC flags from globals.hpp to GC specific files
- Next message: RFC: C2 Object Initialization - Using XMM/YMM registers
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 2018-04-05 11:46, Stefan Karlsson wrote:
On 2018-04-05 11:42, Stefan Johansson wrote:
On 2018-04-05 08:11, Stefan Karlsson wrote: Hi all, Please review this patch to move GC flags out of globals.hpp and into GC specific files. http://cr.openjdk.java.net/~stefank/8201136/webrev.01 https://bugs.openjdk.java.net/browse/JDK-8201136 Really nice! It would be even nicer with a few newlines in the VMFLAGS and GCFLAGS macros, I think it would improve readability. I also used PrintFlagsFinal and checked that no flags were lost in the move. Thanks StefanJ! Here are new webrevs with a cleanup patch proposed by StefanJ. Look at the patch to see the correct indentation. http://cr.openjdk.java.net/~stefank/8201136/webrev.02.delta http://cr.openjdk.java.net/~stefank/8201136/webrev.02 Look fantastic :)
StefanJ
Thanks, StefanK
Thanks, Stefan This is one step towards: https://bugs.openjdk.java.net/browse/JDK-8200729 - Conditional compilation of GCs
With this patch we only have to update gcglobals.hpp when adding new GCs. Thanks, StefanK
- Previous message: RFR: 8201136: Move GC flags from globals.hpp to GC specific files
- Next message: RFC: C2 Object Initialization - Using XMM/YMM registers
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]