RFR: 8200524 - AArch64: CPUFeature and Flag enums are not passed through JVMCI (original) (raw)

stewartd.qdt stewartd.qdt at qualcommdatacenter.com
Thu Apr 5 12:41:33 UTC 2018

Thanks Felix!

From: Felix Yang [mailto:felix.yang at linaro.org] Sent: Wednesday, April 4, 2018 9:34 PM To: stewartd.qdt <stewartd.qdt at qualcommdatacenter.com> Cc: hotspot-dev at openjdk.java.net Subject: Re: RFR: 8200524 - AArch64: CPUFeature and Flag enums are not passed through JVMCI

That looks good to me (not an official reviewer). There are some trailing spaces in your original patch, I have modified and pushed: http://hg.openjdk.java.net/jdk/hs/rev/46b2f783116c Make sure you have jcheck enabled next time. Reference: http://openjdk.java.net/projects/code-tools/jcheck/

Thanks, Felix

On 31 March 2018 at 01:48, stewartd.qdt <stewartd.qdt at qualcommdatacenter.com<mailto:stewartd.qdt at qualcommdatacenter.com>> wrote: Might I get a sponsor for this change?

http://cr.openjdk.java.net/~dstewart/8200524/webrev.01/

Thank you, Daniel

-----Original Message----- From: stewartd.qdt Sent: Friday, March 30, 2018 12:12 PM To: Vladimir Kozlov <vladimir.kozlov at oracle.com<mailto:vladimir.kozlov at oracle.com>>; stewartd.qdt <stewartd.qdt at qualcommdatacenter.com<mailto:stewartd.qdt at qualcommdatacenter.com>>; hotspot-dev at openjdk.java.net<mailto:hotspot-dev at openjdk.java.net> Subject: RE: RFR: 8200524 - AArch64: CPUFeature and Flag enums are not passed through JVMCI

Thanks, Vladimir.

-----Original Message----- From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com<mailto:vladimir.kozlov at oracle.com>] Sent: Friday, March 30, 2018 12:10 PM To: stewartd.qdt <stewartd.qdt at qualcommdatacenter.com<mailto:stewartd.qdt at qualcommdatacenter.com>>; hotspot-dev at openjdk.java.net<mailto:hotspot-dev at openjdk.java.net> Subject: Re: RFR: 8200524 - AArch64: CPUFeature and Flag enums are not passed through JVMCI

Changes looks good to me. They follow the same code pattern as on other architectures.

Thanks, Vladimir

On 3/30/18 8:35 AM, stewartd.qdt wrote:

Please review this webrev [1] which implements the transfer of AArch64::CPUFeature flags and AArch64::Flag enums over the JVMCI interface.

This patch sets the CPUFeature enums corresponding to which VMVersion flags are set. It also sets the Flag enums corresponding to which use flags have been set on the command line. This mirrors what is done for AMD64. The bug report is filed at [2]. I am happy to modify the patch as necessary. Regards, Daniel Stewart [1] - http://cr.openjdk.java.net/~dstewart/8200524/webrev.00/ [2] - https://bugs.openjdk.java.net/browse/JDK-8200524

More information about the hotspot-dev mailing list