RFR: 8200759: Move GC entries in vmStructs.cpp to GC specific files (original) (raw)

Aleksey Shipilev shade at redhat.com
Thu Apr 5 15:09:18 UTC 2018

On 04/05/2018 01:47 PM, Stefan Karlsson wrote:

*) It feels awkward to move JavaThread::satbmarkqueue and JavaThread::dirtycardqueue, to VMSTRUCTSG1GC, since it is guarded by INCLUDEALLGCS. VMSTRUCTSGC seems more fitting. (Trivia: Shenandoah uses those things too, so they are "shared", even though the implementation is indeed in vm/gc/g1). My follow-up changes change this to INCLUDEG1GC, so in that sense this I don't think it's that awkward. However, if Shenandoah needs to use this then I agree that it needs to be moved. I don't think it needs to be done for this change though.

Yeah, it would probably move under JDK-8154343 later.

#ifdef INCLUDECMS _VMTYPESCMSGC(declaretype,                        _ _declaretopleveltype,               _ _integertype))                       _ #endif #ifdef INCLUDEG1 _VMTYPESG1GC(declaretype,                        _ _declaretopleveltype,              _ _integertype))                      _ #endif I can't really use your suggested constructs, because it won't compile.

Ah, because ifdef is inside the macro. Nevermind.

-Aleksey

More information about the hotspot-dev mailing list