RFR: 8200759: Move GC entries in vmStructs.cpp to GC specific files (original) (raw)

Stefan Karlsson stefan.karlsson at oracle.com
Mon Apr 9 12🔞58 UTC 2018

Thanks, StefanJ.

StefanK

On 2018-04-09 11:34, Stefan Johansson wrote:

On 2018-04-06 10:00, Stefan Karlsson wrote: Hi all,

Since I have a few follow-up changes that depend on the ALLGCSONLY macro introduced in this patch, I'm going to extract that part into a separate RFE, so that if any of the following patches need to be backed out (for some reason) I won't have to back out this change. This is the piece I'm going to push separately: http://cr.openjdk.java.net/~stefank/8200759/webrev.01/src/hotspot/share/utilities/macros.hpp.udiff.html Sound like a plan to push that separately. The rest of patch also looks good. Thanks, StefanJ Thanks, StefanK On 2018-04-04 21:37, Stefan Karlsson wrote: Hi all,

Please review this patch to move GC specific entries in vmStructs.cpp out to GC specific files. http://cr.openjdk.java.net/~stefank/8200759/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8200759 This patch is done in preparation for:  https://bugs.openjdk.java.net/browse/JDK-8200729 - Conditional compilation of GCs This patch also has the nice feature that it removes multiple usages of the GC specific defines in vmStructs.cpp. When new GCs are added only three defines need to be added to vmStructsgc.hpp. Tested locally with test/hotspot/jtreg/serviceability/sa, but will run this through mach5 to find potantial missing includes / forward declarations. Thanks, StefanK

More information about the hotspot-dev mailing list