Hotspot segfaulting on Linux SPARC (original) (raw)

David Holmes david.holmes at oracle.com
Mon Apr 9 12:30:41 UTC 2018

On 9/04/2018 9:23 PM, John Paul Adrian Glaubitz wrote:

On 04/09/2018 01:10 PM, David Holmes wrote:

Here's the output of the java command with the change os::free > :🆓

You didn't apply Zhengyu's patch as well did you? I did apply his patch as well. So, the total changes are:

My suggesting was to change os::free to ::free to match the ::strdup instead of Zhengyu's suggestion to change the ::strdup to os::strdup.

David

diff -r cd4da74e310b src/hotspot/cpu/sparc/assemblersparc.cpp --- a/src/hotspot/cpu/sparc/assemblersparc.cpp Fri Apr 06 19:16:33 2018 +0200 +++ b/src/hotspot/cpu/sparc/assemblersparc.cpp Mon Apr 09 11:23:38 2018 +0000 @@ -49,7 +49,7 @@ uint32t insn = *reinterpretcast<uint32t*>(pc);

// 1. General case: No CTI immediately after other CTI -    assert(!(iscti(prev) && iscti(insn)), "CTI-CTI not allowed."); +    // assert(!(iscti(prev) && iscti(insn)), "CTI-CTI not allowed."); // 2. Special case: No CTI immediately after/before RDPC assert(!(iscti(prev) && isrdpc(insn)), "CTI-RDPC not allowed."); diff -r cd4da74e310b src/hotspot/oscpu/linuxsparc/vmversionlinuxsparc.cpp --- a/src/hotspot/oscpu/linuxsparc/vmversionlinuxsparc.cpp Fri Apr 06 19:16:33 2018 +0200 +++ b/src/hotspot/oscpu/linuxsparc/vmversionlinuxsparc.cpp Mon Apr 09 11:23:38 2018 +0000 @@ -48,7 +48,7 @@ if (vstr != NULL) { // We have a matching line and a valid starting point to the value of // the field, copy the string for keeps. -          string = strdup(vstr); +          string = os::strdup(vstr, mtInternal); break; } }

More information about the hotspot-dev mailing list